Adding a box set again results in losing data, even within another collection

Today I was updating my custom application to extract statistics from my collection based on the XML export. (Mainly amount of money spent per month). So I was testing with a small XML from a test collection I made in the past. In this case it is useful to test my changes with a small XML file.

So I added a couple of box sets to this test collection. Purely by accident I noticed that the box sets in my Main collection are updated too. In this case I noticed purchase price, date and store are overwritten in the main collection when I added the same box set to another collection. So I messed up my main entries. I was able to correct this because I did not sync to my mobile phone yet. This should in my opinion never happen.

Reproduction path:

  • Create 2 collections: Test and Test 2
  • Go to Collection: Test
  • Add for example box set: 7333018038011
    • Add as 2 seperate entries
    • Not sure if it is relevant (did not test that), but in my prefill screen I have Purchase Store and Purchase Price
  • Edit the box set of this movie and give the box set a purchase price of 10 euro and date 01-01-2020 and store bol.com
  • So now both box set have the correct details.

The entry now looks like this:

  • Go to collection: Test 2
  • Add the same barcode again: 7333018038011
    • again as 2 seperate entries
  • The details look like this:
    • Notice: No purchase date, price, store: this is good for this collection.
    • Notice: suddenly there are 4 movies listed (I did not notice this when it went wrong, so before I wrote this reproduction path)
    • Now go to Collection Test and go to the same box set
    • Notice: same 4 movies listed, but purchase store, date and price are overwritten/gone on box set!
    • In the folder view it is still listed as 2 movies for this box set (but I think this makes sense):

This does not only happen between different collection, but also within the same collection (add the same box set to the same collection again). So you are unable to add the same box set twice. In case you want to add it again because you have a duplicate in a different condition, you are unable to do so.

I assume you also lose all other box set information if you made modifications like covers and title. However I did not test this.

I did not find any issues with the movies itself within the box set. Only with the box sets itself. Also no issue with single movie entries.

To wrap up:

  • Unable to add the same box set (same barcode) more than once.
    • They are sort of merged into each other, even between different collections
    • Adding the same box set again should never overwrite already existing data
  • You are able to add the same movie (same barcode) more than once.

I think box sets should behave the same as single movie entries. Do not let them influence each other and allow to have the same box set more than once. Luckily I noticed the problem in time, otherwise I lost data.

This has been fixed as of this morning, it was reported about a month ago for the first time, but was apparently broken for way longer already. Not sure how it never got noticed.

I think that what we fixed solves what you are seeing?

I will do some testing later today and report back.

I checked again and it is now sort of fixed but still broken. This time a new box set is created with the addition of (1) even if it is in a different collection. This is not really an issue. However if you follow the following steps something weird happens:

  • Add 7333018038011 to Collection 1 as separate entries
    • Give the box set a price, store and date
  • Add 7333018038011 to Collection 2 as separate entries
  • In Collection 2, go via the edit screen of 1 of the 2 movies to the edit box set screen:
  • Now rename the box set from 28 Years Later (1) to 28 Years Later and Save
  • Immediately click on the edit button for the box set again. Now the box set appears to have got the date, price and store you entered in Collection 1. Don’t save, cancel
  • In the edit screen of the movie: save to close
  • The movie is added to the boxset in collection 1, this image is from the boxset in collection 2. So you see it in collection 1 as well:
  • The other movie that was part of the box set in collection 2 is now the only movie left (makes sense if the other movie is now part of the other box set:
  • Now open the edit screen of this movie that is now the single entry in this box set
  • Edit the box set and it shows the details of the box set that is in collection 1, now this box set also shows the price, date en store you entered in collection 1:
  • Don’t save the box set
  • Save the movie dialog. Now the movie is also added to the box set in collection 1.
  • Now the second box set is gone (checked at the Mange pick lists Box set section):

I am not 100% sure, but if you directly edit the box set without going through the movie edit screen this does not happen. When you edit the movies and save them, they are added to the other box set.

If you want to movie the movie back to the other box set again this is not possible:

it is always added to the first one.

I assume this all goes wrong because the box set has no id and the name of the box set is the identifier if I look at the html for this list.

2 suggestions:

  1. make it all work

  2. in case 1 is not feasable: block dublicate box set names even if they are in different collection. Give an error dialog or something to tell it is not allowed to have duplicate names.

Mobile already “solved” this issue:

Phew, what a big post again.. I’m just grabbing one line:

Now rename the box set from 28 Years Later (1) to 28 Years Later and Save

I understand you would like to have a name “without (1)” in there, and we could go a long route by changing this all, but right now, we’re not.

We will get a warning there like mobile which would solve this. We’ll try and implement that.

For now, just don’t change the name and keep it as (1).

Sounds like a great solution. Then mobile and web have the same limitation. Better ‘not allowing duplicates’ then messing it all up like I did.

1 Like

We just uploaded this solution to the web-app for movie, book and music!

Didn’t check it well but looks like it is working properly :slight_smile:

Now we can’t mess up our database anymore by accident.

1 Like